URGENT: Uninstallation deletes entire folder.

URGENT: Uninstallation deletes entire folder.

Postby TheGrimLavaLamp » 12 Jul 2012, 07:47

As stated in the title, uninstalling maniaplanet removes its entire folder. If this is the default folder this is probably fine. If the folder shares any other data it is SEVERELY BAD.

I originally installed to my games directory, expecting subfolders to be created for individual games (shootmania) and when I noticed the clutter, uninstalled ManiaPlanet, which then deleted my entire 'Games' directory.

I would describe it as irresponsible to continue distributing the beta until this is fixed. I'm recovering data, but as I make my living in the gaming community and I've lost game saves this could very well affect my livelihood. I'm just glad it didn't happen in the Program Files folder, or else I'd be even more severely boned.

Yes, I know everyone should backup everything, but that's not the reality and this problem needs fixing.

Thanks for your time. I did install the game after and it's pretty fun.
TheGrimLavaLamp
 
Posts: 9
Joined: 12 Jul 2012, 07:40

Re: URGENT: Uninstallation deletes entire folder.

Postby maniaracer » 12 Jul 2012, 22:40

TheGrimLavaLamp wrote:As stated in the title, uninstalling maniaplanet removes its entire folder. If this is the default folder this is probably fine. If the folder shares any other data it is SEVERELY BAD.


The only way this could potentially happen is if you had changed the default install dir. from \\Games\Shootmania to \\Games, for example. If you had done this (bad idea tbh), then the uninstall should not remove ALL data (folders/files) from \\Games; if so Nadeo need to fix asap. :thx:
maniaracer
 
Posts: 75
Joined: 16 Sep 2011, 12:30
Location: UK

Re: URGENT: Uninstallation deletes entire folder.

Postby TMarc » 12 Jul 2012, 22:42

:shock:
Did you have other games than just ManiaPlanet and ShootMania there?
ManiaPlanet 3.1 RCx: RC3/4 quick fix wishes.
Other bug and crash reports please post here, try the current debug version.

Centralised links to infos about ManiaPlanet, FAQ, Support, Wiki, Creative contents, Community activities and much more.
User avatar
TMarc
 
Posts: 9829
Joined: 05 Apr 2011, 19:10
Location: Europe

Re: URGENT: Uninstallation deletes entire folder.

Postby Gugli » 13 Jul 2012, 11:21

I made some tests : during your first installation, you should have seen a warning saying
"The directory XXXX already exists. Would you like to install to that directory anyway? "

I admit this message could be more clear concerning the behaviour of the Uninstall process. I'll see if it's possible to change it to something more explicit (quite complicated though, because of localisations).

The other hand of the problem is : if we only delete installed files, the uninstall won't be clean (an ulterior update can add files for example, those wouldn't be deleted). Since the "clean uninstall" issue concern everyone, we still favour this method.

I hope you will understand our choice.
--
(>~_~)> ═╦═ ╔╦╗ <(~_~<)
User avatar
Gugli
Nadeo
Nadeo
 
Posts: 423
Joined: 14 Jun 2010, 17:35
Location: Mon PC est à Paris, mais mon coeur rode dans les forêts de Lozère

Re: URGENT: Uninstallation deletes entire folder.

Postby TheGrimLavaLamp » 13 Jul 2012, 15:23

Right now there are 12 files in the ManiaPlanet folder and 2 subfolders. I'd recommend compartmentalizing all updates to either change existing files in the root directory or add files to the subfolders. This way you can tell your uninstaller to 'delete these 12 files and these 2 subfolders then check the folder and, if it is empty, delete it.' rather than having it delete everything within the folder.

An alternative would be to log any additional files that are created by a patch in a text file which the uninstaller references.

The current implementation is lazy and dangerous for the user (to be blunt). If I had installed to C:\ would it have formatted my hard drive? That's working as intended?

Even a message at the installer isn't good enough (virtually every person installs things on autopilot-no-brain-activity-mode and they're not expecting your program to risk the entire contents of their hard drive). The uninstaller needs to be changed.
TheGrimLavaLamp
 
Posts: 9
Joined: 12 Jul 2012, 07:40

Re: URGENT: Uninstallation deletes entire folder.

Postby TMarc » 14 Jul 2012, 00:00

Similar happened here: viewtopic.php?f=10&t=12150 :oops:
ManiaPlanet 3.1 RCx: RC3/4 quick fix wishes.
Other bug and crash reports please post here, try the current debug version.

Centralised links to infos about ManiaPlanet, FAQ, Support, Wiki, Creative contents, Community activities and much more.
User avatar
TMarc
 
Posts: 9829
Joined: 05 Apr 2011, 19:10
Location: Europe

Re: URGENT: Uninstallation deletes entire folder.

Postby TheGrimLavaLamp » 14 Jul 2012, 01:34

I have a third, ultralazy implementation.

If you are going to keep deleting the entire contents of the install directory this is probably the easiest solution to implement.

Make it so that, whatever directory is given, a \maniaplanet is added to the end.

e.g. if I say 'install to C:\' then install to C:\maniaplanet

Now you've for sure created a directory that isn't (remotely) likely to be user-defined or system vital and you can delete it with minimal concerns. Now your programmers can still be super lazy about writing the uninstaller without any potentially severe negative consequences.

Do something now please.

Another thread with a user losing data has already sprung up (as linked in another post above). You're messing up people's computers.
TheGrimLavaLamp
 
Posts: 9
Joined: 12 Jul 2012, 07:40

Re: URGENT: Uninstallation deletes entire folder.

Postby TMarc » 14 Jul 2012, 09:56

And give a warning that there are more things than belongs to ManiaPlanet.
Or stop uninstall on personal documents folder and say the user has to delete himself manually in this case.
ManiaPlanet 3.1 RCx: RC3/4 quick fix wishes.
Other bug and crash reports please post here, try the current debug version.

Centralised links to infos about ManiaPlanet, FAQ, Support, Wiki, Creative contents, Community activities and much more.
User avatar
TMarc
 
Posts: 9829
Joined: 05 Apr 2011, 19:10
Location: Europe

Re: URGENT: Uninstallation deletes entire folder.

Postby DeVxC » 14 Jul 2012, 11:36

I don't get it so if i installed Shootmania like this
"E:\Gry\ManiaPlanet" (where "Gry" is my main folder for games)
and
"C:\Documents and Settings\DeV\Moje dokumenty\ManiaPlanet" (it's profile folder)
does this means that after uninstallation my folders ("Moje dokumenty" and "Gry") will be completely empty ?
DeVxC
 
Posts: 12
Joined: 04 Jul 2012, 12:26

Re: URGENT: Uninstallation deletes entire folder.

Postby TMarc » 14 Jul 2012, 12:09

DeVxC wrote:I don't get it so if i installed Shootmania like this
"E:\Gry\ManiaPlanet" (where "Gry" is my main folder for games)
and
"C:\Documents and Settings\DeV\Moje dokumenty\ManiaPlanet" (it's profile folder)
does this means that after uninstallation my folders ("Moje dokumenty" and "Gry") will be completely empty ?

No, this should be fine.
But until there is no fix or no other advice, please don't uninstall ManiaPlanet 2.0 at all, just to be sure.
ManiaPlanet 3.1 RCx: RC3/4 quick fix wishes.
Other bug and crash reports please post here, try the current debug version.

Centralised links to infos about ManiaPlanet, FAQ, Support, Wiki, Creative contents, Community activities and much more.
User avatar
TMarc
 
Posts: 9829
Joined: 05 Apr 2011, 19:10
Location: Europe

Next

Return to ManiaPlanet Reports

Who is online

Users browsing this forum: No registered users and 1 guest