Page 2 of 2

Re: [SMART] Plugin SpectatorQueue 1.1

Posted: 24 Oct 2012, 17:22
by insomnia-yamyam
vni wrote:Fix: Don't use the Waitlist-Trigger! Nobody cares about who is waiting.
You must be kidding... :o
But i don't know if sarcasm and irony is very helpful or constructive
if someone is reporting a bug or logical failure. :?

False: Why should there be a Waitinglist Trigger if we can't use it :?:
By the way: I do care if a spectator is changing from spec mode to the waiting list. Indeed.
So i think a lot of people cares IF someone is waiting and WHO is waiting. Indeed.

Thats one of the main senses of this plugin and a "queue-waitinglist-widget" where you also could see the names of the player who are currently in the waitinglist and at which position would be also an improvement, but not very important now, just mentioned it. :D

Another point:
There is a SpectatorQueuePlay-Trigger which we can use to make a chat output if a player changes from spec to play mode. great. but then it would be useful to also add a SpectatorQueueSpec-Trigger to show if the player changes from play to spec mode. Thank you! (...not for your ironic sarcasm, but for everything else)

Re: [SMART] Plugin SpectatorQueue 1.1

Posted: 24 Oct 2012, 18:59
by vni
I think there's a general misunderstanding what Triggers are and what they are used for.

Triggers are hooks that can be used by other plugins to perform some action. The trigger "SpectatorQueueJoinWaitlist", for example, will be used in future for some kinda plugin that displays the waitinglist as widget for spectators. Triggers are not just for Sounds and Texttriggers (even if they can be used that way). If I go and filter triggers just to prevent TextTriggers from reacting on every trigger, there will be malfunctions and confusing behaviours during coding new plugins that rely on triggers to be fired on a special event.

Oh dude, so often the word "trigger" in one paragraph..tri-trig-trigg-igigigiger, I hope this makes things clearer, I feel like I am talking french, but I don't.

A workaround could be the text "Player XXX joined the game via the waitinglist." or sthg like that, via the "SpectatorQueuePlay"-Trigger, as it is not possible to join the game without the waitinglist while this plugin is active.

Re: [SMART] Plugin SpectatorQueue 1.1

Posted: 01 Nov 2012, 01:19
by zargono
Hi,

I am having a weird bug, don't know if it's an error in my config (i leave max_players and max_waitinglist to 0).
Here is the bug: I'm running a Joust server with 5 player slots. I noticed several times when there are 4 players connected, I'm stuck in the waiting list whereas there's a free player slot.

Maybe that's a bug related to SM itself because sometimes we can't even join if a player went from player to spectator without leaving the server.

Any idea?

Re: [SMART] Plugin SpectatorQueue 1.1

Posted: 01 Nov 2012, 11:48
by vni
Hi,

well, I guess the Joust mode has it's own Spectator/Player handling so I doubt the plugin is useful for that gamemode. But I will have a look at it (I did not try it in Joust yet :oops:)

Re: [SMART] Plugin SpectatorQueue 1.1

Posted: 01 Nov 2012, 21:02
by zargono
I think it's working the right way even in Joust mode, because when you're waiting in the Joust rotation queue you're not considered as a spectator (the widget doesn't show up). I tend to set up a low player limit on Joust servers because that way the players get less bored when waiting for their next round.
Instead, the spectators are waiting longer before they can get in, and that's where your plugin is useful, they just subscribe to the waiting list until a player leaves the server.
Thanks for looking at it. :)

EDIT : I think when someone joins as a player, and then moves to spectator without leaving the server, he still occupies one player slot.

One more thing. When trying to use the "move worst players to spec" option, nothing happens. I see the calculation is based on players ranking, but on Joust mode, it should be based on the number of winning rounds. Not sure when several players have the same worst score, maybe select a random one.

If you have some time to check all this, it would be really great. Thanks anyway for all your work, that's amazing. :)