Feedback and Reports for Release v0.15

ManiaControl, the completely new designed and easy to use controller managing all your Maniaplanet server.

Moderators: Jocy, Wabbitface, steeffeen, NADEO

User avatar
Lumpik
Posts: 41
Joined: 04 Jan 2015, 22:00
Contact:

Re: Feedback and Reports for Release v0.15

Post by Lumpik »

Hi,

I have issue with removeMenuItem() function when using the admin options ($playerAction parameter = false).

I've added a Quad() into the admin+user menu (both works) and i want to remove those icon.

Icon is removed from user menu with :

Code: Select all

$this->maniaControl->actionsMenu->removeMenuItem(69, true);
But it's not removed from admin menu with :

Code: Select all

$this->maniaControl->actionsMenu->removeMenuItem(69, false);
I've tried other numbers than 69 (with addMenuItem() + removeMenuItem()) but it always works with "true" and never with "false".

Could you tell me what's wrong ?
The code in https://github.com/ManiaControl/ManiaCo ... nsMenu.php looks fine...
User avatar
Lumpik
Posts: 41
Joined: 04 Jan 2015, 22:00
Contact:

Re: Feedback and Reports for Release v0.15

Post by Lumpik »

OK, i've found the bug.
We both had read the code too fast...

In https://github.com/ManiaControl/ManiaCo ... nsMenu.php :
public function removeMenuItem($order, $playerAction = true) {
if ($playerAction) {
if (isset($this->playerMenuItems[$order])) {
unset($this->playerMenuItems[$order]);
}
} else {
if (isset($this->playerMenuItems[$order])) {
unset($this->adminMenuItems[$order]);
}
}
$this->rebuildAndShowMenu();
}
User avatar
Lumpik
Posts: 41
Joined: 04 Jan 2015, 22:00
Contact:

Re: Feedback and Reports for Release v0.15

Post by Lumpik »

I still have ManiaControl v0.156 and "/admin coreupdate" don't update to v0.157 :(
User avatar
Lumpik
Posts: 41
Joined: 04 Jan 2015, 22:00
Contact:

Re: Feedback and Reports for Release v0.15

Post by Lumpik »

Our permissions are OK, as we're using 777.

Check your release, there's no MC v0.157 in http://www.maniacontrol.com/servers
User avatar
Lumpik
Posts: 41
Joined: 04 Jan 2015, 22:00
Contact:

Re: Feedback and Reports for Release v0.15

Post by Lumpik »

v0.156 was already the last version before I mentioned the bug.
kremsy wrote:Thanks for the report, fixed and update released!
So what did you mean by "udpate released" ?
If you meant only on GitHub, could we have the update released in ManiaControl too please ?
Post Reply

Return to “ManiaControl”

Who is online

Users browsing this forum: No registered users and 2 guests