I am really happy of taking part in this project, I thanks Reaby for allowing me to join the project.
Developper for The next generation, Clean and Powerfull controller eXpansion for your SM & TM server . Working on eXpansion² with full MP4 support and many other awesome features...
Lots have been done in few last weeks, we have squared out bugs and memory leaks and the plugin pack runs quite good already, dedimania is now extracted from the plugin pack to encourage developers to build for manialive
Nice Lap mode in it (on local record) thk oliverde8
But, i read the code, and there are mistakes in LocalRecords.php, on onPlayerFinish() function you don't manage lap mode (line 173: return if lap mode) so you don't save race time, you only save lap time on onPlayerFinishLap()
onPlayerFinish() : when player finish race (lap or not lap mode)
onPlayerFinishLap() : when player finish a lap (only lap mode)
CT*ImHoTep ModLap Championship
Le jour où l'on mettra les cons sur orbite, y en a qui n'ont pas fini de tourner ...
4lturbo wrote:Nice Lap mode in it (on local record) thk oliverde8
But, i read the code, and there are mistakes in LocalRecords.php, on onPlayerFinish() function you don't manage lap mode (line 173: return if lap mode) so you don't save race time, you only save lap time on onPlayerFinishLap()
onPlayerFinish() : when player finish race (lap or not lap mode)
onPlayerFinishLap() : when player finish a lap (only lap mode)
Thanks,
if 5 laps track for exemple the last lap won't send a onPlayerFinishLap() but a onPlayerFinish()? Am I correct?
I thought both events were sent
Developper for The next generation, Clean and Powerfull controller eXpansion for your SM & TM server . Working on eXpansion² with full MP4 support and many other awesome features...
if there are 5 laps :
1st lap : onPlayerFinishLap();
2nd lap : onPlayerFinishLap();
3rd lap : onPlayerFinishLap();
4th lap : onPlayerFinishLap();
5th lap : onPlayerFinishLap(); and onPlayerFinish();
CT*ImHoTep ModLap Championship
Le jour où l'on mettra les cons sur orbite, y en a qui n'ont pas fini de tourner ...
Then what I did is ok
I just take in account every lap individually, and ingore the onPlayerFinish as it has the sum of all the laps. At the moment records are considered on 1 lap only. The best record is the one with the fastest lap not the one that did the 5 laps the fastest
YOu can configure to have record based on total amount of laps ore based on best lap time. You can switch from 1 to another without problem but can not have both at the same time.
Developper for The next generation, Clean and Powerfull controller eXpansion for your SM & TM server . Working on eXpansion² with full MP4 support and many other awesome features...
ok, for those who play in lap mode, final time and lap time are important, like F1 grand prix, there are lap record and race record . Otherwise so much play in Time Attack mode ( time are lap time)
CT*ImHoTep ModLap Championship
Le jour où l'on mettra les cons sur orbite, y en a qui n'ont pas fini de tourner ...
4lturbo wrote:ok, for those who play in lap mode, final time and lap time are important, like F1 grand prix, there are lap record and race record . Otherwise so much play in Time Attack mode ( time are lap time)
I understand it could be changed but we have frozen developement of new features, si it will be on the next version
Developper for The next generation, Clean and Powerfull controller eXpansion for your SM & TM server . Working on eXpansion² with full MP4 support and many other awesome features...