Maniaplanet Forum

haenry wrote: Also that's some huge amount of lines of code.
And these variable declarations already cry for structs.

Code: Select all

			declare Text[] 		Buddies_Login 						for Page;
			declare Text[] 		Buddies_Presence 					for Page;
			declare Text[] 		Buddies_ServerLogin 				for Page;
			declare Text[] 		Buddies_ServerName 					for Page;
			declare Text[] 		Buddies_ServerModeInfos 			for Page;
			declare Text[] 		Buddies_ServerJoinLink 				for Page;
			declare Text[]		Buddies_ServerPlayersCountInfos 	for Page;
			declare Real[] 		Buddies_ServerPlayersCountRatio 	for Page;
			declare Boolean[]	Buddies_Server_IsPrivate 			for Page;
			declare Boolean[] 	Buddies_Server_IsLobby 				for Page;
			declare Boolean[] 	Buddies_Server_IsFull 				for Page;;

This is not really nice code indeed .
Multiple arrays... I don't know the language but would be better to use a dictionary array or even better use objects (object oriented programming). Less chance of making errors, resulting in crashes, etc etc etc.

Haven't encountered anything weird so far except for some missing animations - for example the dropdown animation when clicking on the status menu and the animation when opening a chat with a player.

I could only repeat comments above about listing and length of messages across the screen. Apart from that, I have seen no issues yet - nice work!

Very nice opportunity to replace chat with own plugin

> Sorry for doublepost <

Pfff, after small modifications your new chat looks like this:



DOMINA TAKING OVER MANIAPLANET
IT HAS BEGUN
GO SAVE YOUR WIFE AND CHILDREN

Is it supposed to be or is there just your musicplayer plugin? ^^

Probably not a request thread but
I'd prefere something like steam-overlay instead of what we have now.


Also @Cerovan :

When the buddylist is opened and I want to join a friend whom is playing on a private server then I need to close the buddylist first before I can type in the prompt.
Could this be fixed?

domino54 wrote:> Sorry for doublepost <

Pfff, after small modifications your new chat looks like this:

...

What you said let me think that the design has changed but I can't see the new chat design...
I placed the chat.script.txt in the folders that i created myself but I don't see any new design ?
Has the design changed ?

However when I write an url, a link is created so it seems that this new script is working...

TheBigMiike wrote:

domino54 wrote:> Sorry for doublepost <

Pfff, after small modifications your new chat looks like this:

...

What you said let me think that the design has changed but I can't see the new chat design...
I placed the chat.script.txt in the folders that i created myself but I don't see any new design ?
Has the design changed ?

However when I write an url, a link is created so it seems that this new script is working...

No, he ( domino ) changed the design of the buddylist.

I just replaced my chat with music player