Page 11 of 51
Re: FeedBack & Bugs | Your ideas are important
Posted: 21 Oct 2014, 16:36
by samp
oliverde8 wrote:Why is it such a bad bug?
Well, if records order is wrong, I think it's a bad bug.
I drove an equal time as the 1., at the same session it shows me 2. as it should be.
We play the map again and this bug happens -> I'm 1. and the record holder.
Edit. Okay, investigated the issue a bit more.
It was an old track and the record_date was 0. That's why the sorting failed.
Updating records should update the record_date also.
Re: FeedBack & Bugs | Your ideas are important
Posted: 21 Oct 2014, 17:04
by w1lla
Code: Select all
while ($data = $dbData->fetchStdObject()) {
$record = new Record();
// $this->currentChallengePlayerRecords[$data->record_playerlogin] = $record;
$record->place = $i;
$record->login = $data->record_playerlogin;
$record->nickName = $data->player_nickname;
$record->time = $data->record_score;
$record->nbFinish = $data->record_nbFinish;
$record->avgScore = $data->record_avgScore;
$record->nation = $data->player_nation;
$record->ScoreCheckpoints = explode(",", $data->record_checkpoints);
$record->uId = $this->storage->currentMap->uId;
$records[$i - 1] = $record;
$i++;
}
It seems record date is never added so it will show the latest Ascending record first.
Re: FeedBack & Bugs | Your ideas are important
Posted: 21 Oct 2014, 18:33
by oliverde8
w1lla thanks that can cause issue ^^ I will fix that but it shoulnd't create a problem in the database but I just found a few records that has date missing in them so I need to investigate the cause of that.
For the widgets having correct info it is harder I will try and think of a solution that won't slow down everything
Re: FeedBack & Bugs | Your ideas are important
Posted: 22 Oct 2014, 17:50
by samp
I can confirm that the new records, improved rank and secured time all update the record_date correctly.
So it was just some weird thing with old map that had 0 in record_date.
(Fixed it manually in db)
Re: FeedBack & Bugs | Your ideas are important
Posted: 26 Oct 2014, 11:28
by samp
w1lla wrote:Code: Select all
while ($data = $dbData->fetchStdObject()) {
$record = new Record();
// $this->currentChallengePlayerRecords[$data->record_playerlogin] = $record;
$record->place = $i;
$record->login = $data->record_playerlogin;
$record->nickName = $data->player_nickname;
$record->time = $data->record_score;
$record->nbFinish = $data->record_nbFinish;
$record->avgScore = $data->record_avgScore;
$record->nation = $data->player_nation;
$record->ScoreCheckpoints = explode(",", $data->record_checkpoints);
$record->uId = $this->storage->currentMap->uId;
$records[$i - 1] = $record;
$i++;
}
It seems record date is never added so it will show the latest Ascending record first.
Yes, this causes the bug.
Code: Select all
$record->date = $data->record_date;
should be set when fetching the records in buildCurrentChallangeRecords and getRecordsForMap. Otherwise the existing record will get 0 date if the player just finishes the map but does not improve time.
Re: FeedBack & Bugs | Your ideas are important
Posted: 26 Oct 2014, 12:50
by oliverde8
yes I fixed it in yesterdays commit :
https://github.com/eXpansionPluginPack/ ... e64e159aeb
it is in dev and will move it's way to the master
Re: FeedBack & Bugs | Your ideas are important
Posted: 03 Nov 2014, 01:36
by bass
In regards to the musicbox plugin. In rounds mode with a warm up, after the warm up, the music box announces next song and again announces next song at the conclusion of the match/map which completely skips the song announced after the warm up. This also can and does occasionally allow a song to be randomly selected twice in a row. Is there a way to configure musicbox to ignore a warm up period? Prob not eh? Thought I'd try anyway
Thanks
Re: FeedBack & Bugs | Your ideas are important
Posted: 03 Nov 2014, 15:49
by bass
Think I answered my question... seems to work fine in script mode.. ill use that
Re: FeedBack & Bugs | Your ideas are important
Posted: 03 Nov 2014, 16:04
by reaby
so musicbox in legacy modes has this unwanted behaviour, but for scripted modes it works ok ?
Re: FeedBack & Bugs | Your ideas are important
Posted: 03 Nov 2014, 20:07
by bass
Yes it seems.. but now trying to run rounds.script I cannot get my server to run rank ladder 90k
