Page 4 of 12
Re: Dedicated Server API Client Communication
Posted: 19 Apr 2014, 00:36
by The_Big_Boo
Fixed! I should have looked closer to xmlrpc_encode_request options, as utf-8 charaters were wrongly escaped... Thanks for reporting
@TMarc: Unicode is a character set, not an encoding.
Re: Dedicated Server API Client Communication
Posted: 19 Apr 2014, 00:51
by TheM
The_Big_Boo wrote:Fixed! I should have looked closer to xmlrpc_encode_request options, as utf-8 charaters were wrongly escaped... Thanks for reporting
@TMarc: Unicode is a character set, not an encoding.
Yep, that did the trick! Thanks
Re: Dedicated Server API Client Communication
Posted: 19 Apr 2014, 09:58
by TMarc
The_Big_Boo wrote:Fixed! I should have looked closer to xmlrpc_encode_request options, as utf-8 charaters were wrongly escaped... Thanks for reporting
@TMarc: Unicode is a character set, not an encoding.
I know, but you also know what was meant...
Code: Select all
<?xml version="1.0" encoding="UTF-8"?>
Thanks for fixing it this fast
Re: Dedicated Server API Client Communication
Posted: 19 Apr 2014, 12:29
by Jojo_44
I´ve used cdata as escaping option for the last 2 years which is a pretty cool trick I think. If you use /verbose_rpc_full it´s waaay better to read instead of the entities. Would be cool if you can change that.
Jojo
Re: Dedicated Server API Client Communication
Posted: 19 Apr 2014, 13:39
by The_Big_Boo
Yep, I saw you were using that option ^^ And it seems it's also a good idea to lower request size when sending manialinks! I pushed the change, I hope it doesn't break anything as I don't have the time to test this a lot (I just checked that ManiaLive and ManiaControl were launching fine and that manialinks were showing ingame).
@TMarc: you should thank
him, otherwise I wouldn't have been this fast ^^
Btw, I'm out for a few days and I won't be able to work on this. I'll still check if you report bugs, but won't be able to fix them (or at least, won't be able to test fixes ^^). Happy testing
Re: Dedicated Server API Client Communication
Posted: 20 Apr 2014, 15:31
by The_Big_Boo
kremsy wrote:Edit: found out that it should be no problem in 5.3, was just something different in mind.
Indeed it is 5.3 compatible. Moreover, I almost didn't change anything in the Connection class (the goal being the Xmlrpc itself) so this was written before 5.4 anyway ^^
kremsy wrote:And it would be nice if you can delete the instance by an method which you give the reference to the client object as parameter -> makes much more sence, wrote that into another topic long time ago already.
Yep, that's a nice idea. I was also thinking about fixing a flaw in the factory: if you ask first for a connection with User or Admin level then ask one to the same server with a higher level, you'll still have only the lower level. That's not a common case though.
Edit: thanks for the fix in GbxRemote
Re: Dedicated Server API Client Communication
Posted: 20 Apr 2014, 15:39
by The_Big_Boo
That's why I said it's not a common case. This is just because I know it's there and it doesn't cost me anything to fix it ^^