Page 4 of 5
Re: ManiaControl Feedback and Bugreporting for Release v0.14
Posted: 17 May 2014, 15:24
by steeffeen
yep that's the easy way we planned to go for now
-> allowing to set the match settings file name specific to each server login
(there's something more complex planned but that will take more time)
Re: ManiaControl Feedback and Bugreporting for Release v0.14
Posted: 19 May 2014, 14:06
by chco
I found one thing in regards to timers..
Not sure if it is a feature or a bug
When I set a timer to run only once.. it gets run immediately and then again after the time it has been set.
So it runs twice ..
Cheers,
Charly
Re: ManiaControl Feedback and Bugreporting for Release v0.14
Posted: 19 May 2014, 14:24
by steeffeen
chco wrote:When I set a timer to run only once.. it gets run immediately and then again after the time it has been set.
So it runs twice ..
thanks for the report!
should be fixed in the next version
Re: ManiaControl Feedback and Bugreporting for Release v0.14
Posted: 19 May 2014, 21:28
by chco
steeffeen wrote:yep that's the easy way we planned to go for now
-> allowing to set the match settings file name specific to each server login
(there's something more complex planned but that will take more time)
There's one thing that I think I should mention in regards to the mapmanager.
You have a setting there to change the matchsetting.txt file (you name it tracklist.txt).
I've set it to a different name and that works. Problems is that after MC has been shutdown and the Dedi server.. the setting is back to tracklist.txt. Really annoying that is.
The reason I mention that is because, for the time being, I wrote a small plugin that does evaluate commandline options from Manicacontrol and reads from there the name for the matchsetting .txt file. This way I can easily switch between Royal and Elite, just by running MC with the parameter needed.
The problem I have is with the settingsmanager.
This gives me a success (true value) :
Code: Select all
if(!$this->maniaControl->settingManager->initSetting("MapManager", self::SETTING_MAPLIST_FILE, $file))
Yet when I go into the settings for the mapmanager.. tracklist.txt is in there again. Even after skipping a few maps and such.
Could there be an issue with either the settingsmanager or the combination of the mapmanager and the settingsmanager ?
Re: ManiaControl Feedback and Bugreporting for Release v0.14
Posted: 19 May 2014, 22:12
by steeffeen
chco wrote:Code: Select all
if(!$this->maniaControl->settingManager->initSetting("MapManager", self::SETTING_MAPLIST_FILE, $file))
Yet when I go into the settings for the mapmanager.. tracklist.txt is in there again. Even after skipping a few maps and such.
Could there be an issue with either the settingsmanager or the combination of the mapmanager and the settingsmanager ?
well the mapmanager class uses another setting as the one defined there
simply because the class has a namespace that isn't given by you
the full class name is 'ManiaControl\Maps\MapManager'
also an INIT doesnt change the current value
you need to SET the value
but it usually shouldn't reset the setting if you have changed it properly (ingame)
or did you just try that hacky way of changing it?
Re: ManiaControl Feedback and Bugreporting for Release v0.14
Posted: 20 May 2014, 09:03
by chco
Well actually... I posted the wrong code
This code I tried to see if it made a difference, since it (initsetting) calls the saveSetting procedure.
This is the code used :
Code: Select all
if(!$this->maniaControl->settingManager->setSetting("MapManager", self::SETTING_MAPLIST_FILE, $file))
{
$this->maniaControl->chat->sendInformation('Error saving '.$file." into mapmanager settings", null, false);
}
else
{
In regards to the class name.. you are right. That might be a solution. That means the setsetting procedure accepts classnames that have not been previously initialized, correct ? As it returns true for saving the setting.
And creating a plugin allowing to read arguments from the commandline isn't hacky ..it's something we need currently and this was the safest approach.
The tracklist.txt setting is changed from within the game, so the way it is intended. I have now noticed the setting is gone after the server itself has been shutdown (so php and mysql also). Rebooting the server drops that setting.
steeffeen wrote:
well the mapmanager class uses another setting as the one defined there
simply because the class has a namespace that isn't given by you
the full class name is 'ManiaControl\Maps\MapManager'
also an INIT doesnt change the current value
you need to SET the value
but it usually shouldn't reset the setting if you have changed it properly (ingame)
or did you just try that hacky way of changing it?
Statistics manager
Posted: 22 May 2014, 11:54
by chco
Quick question regarding the statisticsmanager .. Does it take various servers environment into account, like e.g. the Karma plugin does? Cause, as far as I can see, if you run the server as Elite or Royal, all the stats are accumulated.
Cheers,
Charly
Re: ManiaControl Feedback and Bugreporting for Release v0.14
Posted: 22 May 2014, 18:49
by chco
Hmmm.. if I have MP running the Royal server. Later it runs the Elite server (both different dedi masterserver accounts). If I open the stats in the Elite server, it gives me the total stats (both Elite AND Royal)..
I could be mistaken, but in the code I also do not see it store the game environment, but perhaps you don't store that but use different tables. Did not check that. But.. it does show all stats when viewed in the maniacontrol panel->statistics window.