Page 1 of 1

"Bug" Regarding map rpc-methods

Posted: 30 Oct 2011, 17:23
by proma
Note this is not a real bug but an inconvinience for programmers.
Also it is documented so it is not really undefined/unwandet behaviour.

What is the Bug?
The map struct of the Server methods has a flaw.
One member is named wrong (or unintuitive) "Environnement".
How can I reproduce this?
Call any method that returns a map struct via xmlrpc on a server.
What is my expectation of this bug?
The name should be "Environment".

Affected Functions
GetCurrentMapInfo
GetNextMapInfo
GetMapInfo
GetMapList
(list may be incomplete)

Problems
A change might invalidate current server managers, as they "rely" on the error, but this is minor
as with the introduction of the SetApiVersion method it can be circumvented.

Further references:
Quoted from the tm-karma plugin of xaseco2 when using the output of GetCurrentMapInfo:

Code: Select all

plugin.tm-karma-dot-com.php:            $map->environment       = $response['Environnement'];           // "Environnement" is wrong written by nadeo!!!

Re: "Bug" Regarding map rpc-methods

Posted: 30 Oct 2011, 18:40
by jonthekiller
Environnement is in French^^. Nadeo has written this in French but yes in English, it's better.

Re: "Bug" Regarding map rpc-methods

Posted: 30 Oct 2011, 18:47
by Xymph
These minor French/English misspellings have been in the dedicated servers since the TMN/TMO/TMS one. Another well-known example is Payed instead of Paid. ;) They probably won't be fixed in order to maintain compatibility with server controllers.

Re: "Bug" Regarding map rpc-methods

Posted: 30 Oct 2011, 19:15
by proma
Yeah I believe this too but maybe give it a try ^^
TMC has some more movement going on than the older "versions".

For compatibility one could also double this field at the cost of more bandwidth being used.

Re: "Bug" Regarding map rpc-methods

Posted: 01 Nov 2011, 14:29
by nocturne
You'll find more of these french words mixed in... Though, I hope they don't change them -- the simple change from 'Challenge' to 'Map' has proved devastating enough to backwards compatibility as it is.